Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Dampening and Salvager Docking #1298

Closed
wants to merge 15 commits into from

Conversation

Kesiath
Copy link
Contributor

@Kesiath Kesiath commented Apr 29, 2024

About the PR

This PR changes a major game mechanic, and also introduces two new flatpack items: the iron mass and docking magnet. The iron mass and docking magnet both act as docks, but can be wrenched, rotated, and moved into position both on and off your vessel or salvage/asteroids.

This PR also disabled linear speed dampening so your flight in space does not slow down like it currently does. This applies to all unanchored grids, so ships and asteroids/salvage. Rotational dampening was increased quite a bit so ships will stop spinning much faster, as will asteroids/salvage.

Huge thanks to Stagnation in the discord for help with the sprites.

Why / Balance

Space should be dangerous, and the fear of losing your vessel while on EVA should be ever-present. Taking the time to do salvage/mining right with safety equipment (the new docking tools, and/or a grappling hook) and keeping a pilot onboard to make sure your ship doesn't go drift off into space should be more important in our RP and game mechanics.

How to test

Spawn a ship to test the space changes, and use the flatpack vendor to get the two new machines. The new machines work the same as docks.

Media

image

Changelog
🆑

  • add: Added the iron mass and docking magnet, new salvager tools.
  • tweak: Changed the space drag in the sector, so now you hold all linear momentum.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

RSI Diff Bot; head commit 052a5f7 merging into f009aa0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Doors/Airlocks/Glass/ironmass.rsi

State Old New Status
assembly Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_unlit Added
open Added
opening Added
opening_unlit Added
panel_closing Added
panel_open Added
panel_opening Added
welded Added

Resources/Textures/_NF/Structures/Doors/Airlocks/Glass/magnet.rsi

State Old New Status
assembly Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_unlit Added
open Added
opening Added
opening_unlit Added
panel_closing Added
panel_open Added
panel_opening Added
welded Added

Edit: diff updated after 052a5f7

@UncaughtEx
Copy link
Contributor

It serves well to be prepared!

@Green-00ff00
Copy link

My largest reservation is if a pilot/captain becomes incapacitated at the helm; they'd effectively continue on indefinitely until some external force stops them. That could be something to make medical/SAR a lot more annoying and fiddly, which may not be considered a good thing.

@@ -66,9 +66,9 @@ public sealed partial class ShuttleComponent : Component
/// Damping applied to the shuttle's physics component when not in FTL.
/// </summary>
[DataField("linearDamping"), ViewVariables(VVAccess.ReadWrite)]
public float LinearDamping = 0.05f;
public float LinearDamping = 0.00f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if its a good idea to have this 0 as possible lag issue?
Also in general this should be a per ship toggle options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah in testing things infinitely floating off does have some issues, that said the current value of .05 feels like way too much, .002 has a lot of drift while definitely slowing vehicles down over a while so I'll probably switch it over to that for the PR

@Kesiath
Copy link
Contributor Author

Kesiath commented Apr 29, 2024

apparently impossible to just make asteroids innate heavier so their dampening is just a bit higher then ships, although they still float for quite a ways - ships float more naturally and of course retain their speed better - ultimately, and maybe done with this PR if I can figure it out, would be implementing a UI button on the ship, or a machine, which controls dampening (0 for cruising, 0.05 for maneuvering, 0.95 for parking perhaps?)

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Apr 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the UI label Apr 29, 2024
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Apr 29, 2024
@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dvir001
Copy link
Contributor

dvir001 commented Jul 8, 2024

Another PR aim to patch this issue

@dvir001 dvir001 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants